steveloughran commented on a change in pull request #2216:
URL: https://github.com/apache/hadoop/pull/2216#discussion_r477427688
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientContext.java
##########
@@ -24,34 +24,17 @@
*/
public class AbfsClientContext {
- private ExponentialRetryPolicy exponentialRetryPolicy;
- private AbfsPerfTracker abfsPerfTracker;
- private AbfsCounters abfsCounters;
-
- public AbfsClientContext withExponentialRetryPolicy(
- final ExponentialRetryPolicy exponentialRetryPolicy) {
+ private final ExponentialRetryPolicy exponentialRetryPolicy;
+ private final AbfsPerfTracker abfsPerfTracker;
+ private final AbfsCounters abfsCounters;
+
+ public AbfsClientContext(
Review comment:
you can make this package private now, as nobody should be creating
directly
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientContext.java
##########
@@ -0,0 +1,68 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+/**
+ * Class to hold extra configurations for AbfsClient and further classes
+ * inside AbfsClient.
+ */
+public class AbfsClientContext {
Review comment:
ok, don't worry about validation. What you have done is great -all that
is left is to make the AbfsClientContext package private so forcing everything
to go through the builder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
