steveloughran commented on a change in pull request #743:
URL: https://github.com/apache/hadoop/pull/743#discussion_r479679077
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
##########
@@ -670,6 +670,27 @@ public boolean rename(Path src, Path dst) throws
IOException {
}
}
+ /**
+ * Rename files/dirs.
+ */
+ @Override
+ @SuppressWarnings("deprecation")
+ public void rename(final Path src,
+ Path dst,
+ final Options.Rename... options)
+ throws IOException {
+ fs.rename(src, dst, options);
Review comment:
if options = NONE and the dest exists, the call MUST raise an exception.
I've just reviewed this carefully and added comments to clarify
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
