[
https://issues.apache.org/jira/browse/HADOOP-11452?focusedWorklogId=476149&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476149
]
ASF GitHub Bot logged work on HADOOP-11452:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Aug/20 19:01
Start Date: 29/Aug/20 19:01
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#743:
URL: https://github.com/apache/hadoop/pull/743#discussion_r479679604
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java
##########
@@ -670,6 +670,27 @@ public boolean rename(Path src, Path dst) throws
IOException {
}
}
+ /**
+ * Rename files/dirs.
+ */
+ @Override
+ @SuppressWarnings("deprecation")
+ public void rename(final Path src,
+ Path dst,
+ final Options.Rename... options)
+ throws IOException {
+ fs.rename(src, dst, options);
+
+ Path srcCheckFile = getChecksumFile(src);
+ Path dstCheckFile = getChecksumFile(dst);
+ if (fs.exists(srcCheckFile)) { //try to rename checksum
+ fs.rename(srcCheckFile, dstCheckFile, Options.Rename.OVERWRITE);
Review comment:
interesting thought. The only current option is trash; don't know if we
should retain that. I will add a comment in the javadocs of Options.Rename on
this topic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 476149)
Time Spent: 50m (was: 40m)
> Make FileSystem.rename(path, path, options) public, specified, tested
> ---------------------------------------------------------------------
>
> Key: HADOOP-11452
> URL: https://issues.apache.org/jira/browse/HADOOP-11452
> Project: Hadoop Common
> Issue Type: Task
> Components: fs
> Affects Versions: 2.7.3
> Reporter: Yi Liu
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Attachments: HADOOP-11452-001.patch, HADOOP-11452-002.patch,
> HADOOP-14452-004.patch, HADOOP-14452-branch-2-003.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently in {{FileSystem}}, {{rename}} with _Rename options_ is protected
> and with _deprecated_ annotation. And the default implementation is not
> atomic.
> So this method is not able to be used outside. On the other hand, HDFS has a
> good and atomic implementation. (Also an interesting thing in {{DFSClient}},
> the _deprecated_ annotations for these two methods are opposite).
> It makes sense to make public for {{rename}} with _Rename options_, since
> it's atomic for rename+overwrite, also it saves RPC calls if user desires
> rename+overwrite.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
