[
https://issues.apache.org/jira/browse/HADOOP-17227?focusedWorklogId=476215&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476215
]
ASF GitHub Bot logged work on HADOOP-17227:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/20 10:32
Start Date: 30/Aug/20 10:32
Worklog Time Spent: 10m
Work Description: steveloughran commented on pull request #2254:
URL: https://github.com/apache/hadoop/pull/2254#issuecomment-683403665
```
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3GuardTool.java:28:import
java.time.Duration;:8: Unused import - java.time.Duration. [UnusedImports]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/s3guard/S3GuardTool.java:763:
public static final String PURPOSE = "destroy the Metadata Store including
its contents": Line is longer than 80 characters (found 92). [LineLength]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:332:
String.format("Argument for %s is not a number: %s", option,
value));: Line is longer than 80 characters (found 81). [LineLength]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:435:
/**: First sentence should end with a period. [JavadocStyle]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:622:
private ScanResult failScan(ScanResult result, int code, String message,
Object...args) {: Line is longer than 80 characters (found 91). [LineLength]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractS3ATestBase.java
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 476215)
Time Spent: 50m (was: 40m)
> improve s3guard markers command line tool
> -----------------------------------------
>
> Key: HADOOP-17227
> URL: https://issues.apache.org/jira/browse/HADOOP-17227
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The s3guard markers audit -expected N command is meant to verify that the
> marker count is N, but
> * it isn't verified if the #of markers is 0, so you can't use it to assert
> that markers have been created
> * it doesn't work for tests where you expect a minimum number of markers.
> It's essentially setting a max #of markers
> Proposed: explicit -min, -max args to declare a specific range of values
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
