[
https://issues.apache.org/jira/browse/HADOOP-15551?focusedWorklogId=477188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-477188
]
ASF GitHub Bot logged work on HADOOP-15551:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Sep/20 12:25
Start Date: 01/Sep/20 12:25
Worklog Time Spent: 10m
Work Description: imbajin opened a new pull request #2265:
URL: https://github.com/apache/hadoop/pull/2265
[JIRA URL](https://issues.apache.org/jira/browse/HDFS-15551)
1. add or improve some logs for adding local & global deadnodes
2. logic improve
3. fix typo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 477188)
Remaining Estimate: 0h
Time Spent: 10m
> Avoid use of Java8 streams in Configuration.addTags
> ---------------------------------------------------
>
> Key: HADOOP-15551
> URL: https://issues.apache.org/jira/browse/HADOOP-15551
> Project: Hadoop Common
> Issue Type: Improvement
> Components: performance
> Affects Versions: 3.2.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Major
> Fix For: 3.2.0
>
> Attachments: hadoop-15551.txt
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Configuration.addTags oddly uses Arrays.stream instead of a more conventional
> mechanism. When profiling a simple program that uses Configuration, I found
> that addTags was taking tens of millis of CPU to do very little work the
> first time it's called, accounting for ~8% of total profiler samples in my
> program.
> {code}
> [9] 4.52% 253 self: 0.00% 0 java/lang/invoke/MethodHandleNatives.linkCallSite
> [9] 3.71% 208 self: 0.00% 0
> java/lang/invoke/MethodHandleNatives.linkMethodHandleConstant
> {code}
> I don't know much about the implementation details of the Streams stuff, but
> it seems it's probably meant more for cases with very large arrays or
> somesuch. Switching to a normal Set.addAll() call eliminates this from the
> profile.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
