[
https://issues.apache.org/jira/browse/HADOOP-17165?focusedWorklogId=478228&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-478228
]
ASF GitHub Bot logged work on HADOOP-17165:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/20 00:00
Start Date: 03/Sep/20 00:00
Worklog Time Spent: 10m
Work Description: tasanuma commented on a change in pull request #2240:
URL: https://github.com/apache/hadoop/pull/2240#discussion_r482607435
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java
##########
@@ -483,6 +501,12 @@ private void recomputeScheduleCache() {
for (Map.Entry<Object, List<AtomicLong>> entry : callCosts.entrySet()) {
Object id = entry.getKey();
+ // The priority for service users is always 0
+ if (isServiceUser((String)id)) {
Review comment:
@sunchao Thanks for your review.
* When DecayRpcScheduler decays, it calls recomputeScheduleCache to
recalculate the priority of all users, including service users, and put them in
the cache. So we had to do this in recomputeScheduleCache as well. Lines
415-421 of the unit test cover this case.
* I moved it from getPriorityLevel to cachedOrComputedPriorityLevel because
I thought it would be a little more efficient to determine if a user is a
service user after looking at the cache information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 478228)
Time Spent: 40m (was: 0.5h)
> Implement service-user feature in DecayRPCScheduler
> ---------------------------------------------------
>
> Key: HADOOP-17165
> URL: https://issues.apache.org/jira/browse/HADOOP-17165
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Priority: Major
> Labels: pull-request-available
> Attachments: HADOOP-17165.001.patch, HADOOP-17165.002.patch,
> after.png, before.png
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In our cluster, we want to use FairCallQueue to limit heavy users, but not
> want to restrict certain users who are submitting important requests. This
> jira proposes to implement the service-user feature that the user is always
> scheduled high-priority queue.
> According to HADOOP-9640, the initial concept of FCQ has this feature, but
> not implemented finally.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
