steveloughran commented on a change in pull request #2272:
URL: https://github.com/apache/hadoop/pull/2272#discussion_r483148755
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java
##########
@@ -503,6 +507,28 @@ public AbfsInputStreamStatistics getStreamStatistics() {
return streamStatistics;
}
+ /**
+ * Since, the value of readAheadBytesRead counter could be arbitrary due to
Review comment:
say what it is rather than why, e,g "number of bytes picked up in async
readahead"
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java
##########
@@ -503,6 +507,28 @@ public AbfsInputStreamStatistics getStreamStatistics() {
return streamStatistics;
}
+ /**
+ * Since, the value of readAheadBytesRead counter could be arbitrary due to
+ * race condition we have a getter for value of this counter at some point
+ * in the operation.
+ * @return bytes read from readAhead at some point of the operation.
+ */
+ @VisibleForTesting
+ public long getBytesFromReadAhead() {
+ return bytesFromReadAhead;
+ }
+
+ /**
+ * Since, the value of remoteBytesRead counter value is dependent on a race
Review comment:
same: explain what the counter is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
