[
https://issues.apache.org/jira/browse/HADOOP-17028?focusedWorklogId=479031&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-479031
]
ASF GitHub Bot logged work on HADOOP-17028:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/20 09:20
Start Date: 04/Sep/20 09:20
Worklog Time Spent: 10m
Work Description: abhishekdas99 commented on pull request #2260:
URL: https://github.com/apache/hadoop/pull/2260#issuecomment-687031356
> I like the lazy eval style
>
> * thread safety: what is the story here?
> * what's the story w.r.t IOExceptions being raised in the init function?
>
> in org.apache.hadoop.fs.impl.FunctionsRaisingIOE we have an interface for
functions which explicilty raise them. Using that or something like it makes
sense here
Thanks @steveloughran for the review.
I have incorporated FunctionsRaisingIOE to take care of IOException. Thanks
for the pointer. Also added synchronized block around initialization of file
system instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 479031)
Time Spent: 1.5h (was: 1h 20m)
> ViewFS should initialize target filesystems lazily
> --------------------------------------------------
>
> Key: HADOOP-17028
> URL: https://issues.apache.org/jira/browse/HADOOP-17028
> Project: Hadoop Common
> Issue Type: Bug
> Components: client-mounts, fs, viewfs
> Affects Versions: 3.2.1
> Reporter: Uma Maheswara Rao G
> Assignee: Abhishek Das
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently viewFS initialize all configured target filesystems when
> viewfs#init itself.
> Some target file system initialization involve creating heavy objects and
> proxy connections. Ex: DistributedFileSystem#initialize will create DFSClient
> object which will create proxy connections to NN etc.
> For example: if ViewFS configured with 10 target fs with hdfs uri and 2
> targets with s3a.
> If one of the client only work with s3a target, But ViewFS will initialize
> all targets irrespective of what clients interested to work with. That means,
> here client will create 10 DFS initializations and 2 s3a initializations. Its
> unnecessary to have DFS initialization here. So, it will be a good idea to
> initialize the target fs only when first time usage call come to particular
> target fs scheme.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
