sunchao commented on a change in pull request #2240:
URL: https://github.com/apache/hadoop/pull/2240#discussion_r483999578
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/DecayRpcScheduler.java
##########
@@ -483,6 +501,12 @@ private void recomputeScheduleCache() {
for (Map.Entry<Object, List<AtomicLong>> entry : callCosts.entrySet()) {
Object id = entry.getKey();
+ // The priority for service users is always 0
+ if (isServiceUser((String)id)) {
Review comment:
Gotcha. Thanks @tasanuma . This looks most good for me. One minor nit is
that the logic for handling service users now is separated into two places.
Another way perhaps is to add this in `computePriorityLevel` which is called by
`recomputeScheduleCache` and `cacheOrComputePriorityLevel`. We need to add an
extra parameter for this method though. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
