mukund-thakur commented on a change in pull request #2257: URL: https://github.com/apache/hadoop/pull/2257#discussion_r484259633
########## File path: hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AFileOperationCost.java ########## @@ -176,6 +176,77 @@ public void testCostOfListFilesOnNonExistingDir() throws Throwable { .plus(GET_FILE_STATUS_FNFE))); } + @Test + public void testCostOfListStatusOnFile() throws Throwable { + describe("Performing listStatus() on a file"); + Path file = path(getMethodName() + ".txt"); + S3AFileSystem fs = getFileSystem(); + touch(fs, file); + verifyMetrics(() -> + fs.listStatus(file), + whenRaw(LIST_STATUS_LIST_OP + .plus(GET_FILE_STATUS_ON_FILE)), + whenAuthoritative(LIST_STATUS_LIST_OP), + whenNonauth(LIST_STATUS_LIST_OP)); +// resetMetricDiffs(); +// fs.listStatus(file); +// if (!fs.hasMetadataStore()) { +// metadataRequests.assertDiffEquals(1); +// } +// listRequests.assertDiffEquals(1); + } + + @Test + public void testCostOfListStatusOnEmptyDir() throws Throwable { + describe("Performing listStatus() on an empty dir"); + Path dir = path(getMethodName()); + S3AFileSystem fs = getFileSystem(); + fs.mkdirs(dir); + verifyMetrics(() -> + fs.listStatus(dir), + whenRaw(LIST_STATUS_LIST_OP Review comment: Sure Thanks :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org