Gaurangi94 commented on a change in pull request #2028:
URL: https://github.com/apache/hadoop/pull/2028#discussion_r485081448



##########
File path: 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
##########
@@ -1588,6 +1588,19 @@ public void stop() {
       this.jobIndexInfo =
           new JobIndexInfo(-1, -1, user, jobName, jobId, -1, -1, null,
                            queueName);
+
+      if (getConfig().getBoolean(
+          JHAdminConfig.MR_HISTORY_APPEND_RM_HOST_TO_HISTORY_FILE_NAME_ENABLED,
+          
JHAdminConfig.DEFAULT_MR_HISTORY_APPEND_RM_HOST_TO_HISTORY_FILE_NAME_ENABLED)) {
+
+        String hostName = getConfig().get(YarnConfiguration.RM_HOSTNAME, "");

Review comment:
       I see that YARN federation feature can have multiple RMs. 
   I created a high availability cluster to check my changes, and noticed that 
one of the RMs (job-cluster-m-0) was listed as the host. 
   
   Is it safe to assume that YARN federation will behave similarly? Please note 
that I used Hadoop 3.2.1 to test this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to