ayushtkn commented on pull request #2305: URL: https://github.com/apache/hadoop/pull/2305#issuecomment-692761784
Thanx @umamaheswararao for the fix, I just had a very quick look. Just want to confirm, In rename, do we need to avoid any scenario like HDFS-15444? Or that is guarded already. Secondly, In resolve result, can we change the constructor directly?, or do we need to have an overloaded constructor to avoid compatibility issues, that might have saved couple of changes as well. The PR title has the wrong jira id, the last digit got missed. Do correct it, before pushing ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
