goiri commented on a change in pull request #2082:
URL: https://github.com/apache/hadoop/pull/2082#discussion_r489728490
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
##########
@@ -250,6 +250,11 @@
String DFS_LEASE_HARDLIMIT_KEY = "dfs.namenode.lease-hard-limit-sec";
long DFS_LEASE_HARDLIMIT_DEFAULT = 20 * 60;
+ String DFS_ROUTER_RPC_RETRY_INTERVAL_KEY =
"dfs.router.rpc.retry.interval.seconds";
+ int DFS_ROUTER_RPC_RETRY_INTERVAL_DEFAULT = 10;
Review comment:
Make it TimeUnit.SECONDS.toXXXX(10)
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/client/HdfsClientConfigKeys.java
##########
@@ -250,6 +250,11 @@
String DFS_LEASE_HARDLIMIT_KEY = "dfs.namenode.lease-hard-limit-sec";
long DFS_LEASE_HARDLIMIT_DEFAULT = 20 * 60;
+ String DFS_ROUTER_RPC_RETRY_INTERVAL_KEY =
"dfs.router.rpc.retry.interval.seconds";
Review comment:
Technically is not seconds but time duration.
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
##########
@@ -557,6 +567,19 @@ private Object invoke(String nsId, int retryCount, final
Method method,
}
// retry
+ try {
Review comment:
Sure, but we should change the logic to match the old style or at least
to not have the two styles together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
