[ https://issues.apache.org/jira/browse/HADOOP-15136?focusedWorklogId=486320&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-486320 ]
ASF GitHub Bot logged work on HADOOP-15136: ------------------------------------------- Author: ASF GitHub Bot Created on: 18/Sep/20 18:10 Start Date: 18/Sep/20 18:10 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #2314: URL: https://github.com/apache/hadoop/pull/2314#issuecomment-695011609 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 31m 20s | trunk passed | | +1 :green_heart: | mvnsite | 1m 16s | trunk passed | | +1 :green_heart: | shadedclient | 48m 22s | branch has no errors when building and testing our client artifacts. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 51s | the patch passed | | +1 :green_heart: | mvnsite | 1m 10s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | shadedclient | 15m 34s | patch has no errors when building and testing our client artifacts. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 29s | The patch does not generate ASF License warnings. | | | | 69m 29s | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2314/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/2314 | | Optional Tests | dupname asflicense mvnsite markdownlint | | uname | Linux 81b973723627 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 2377df38ad2 | | Max. process+thread count | 337 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2314/1/console | | versions | git=2.17.1 maven=3.6.0 | | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 486320) Time Spent: 1h (was: 50m) > Typo in rename spec pseudocode > ------------------------------ > > Key: HADOOP-15136 > URL: https://issues.apache.org/jira/browse/HADOOP-15136 > Project: Hadoop Common > Issue Type: Bug > Components: documentation > Reporter: Rae Marks > Priority: Major > Labels: pull-request-available > Fix For: 3.3.1 > > Time Spent: 1h > Remaining Estimate: 0h > > Location of issue: [rename spec > documentation|https://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/filesystem/filesystem.html#boolean_renamePath_src_Path_d] > The text description for what rename does in the case when the destination > exists and is a directory is correct. However, the pseudocode is not. > What is written: > {code} > let dest = if (isDir(FS, src) and d != src) : > d + [filename(src)] > else : > d > {code} > What I expected: > {{isDir(FS, src)}} should be {{isDir(FS, d)}}. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org