[
https://issues.apache.org/jira/browse/HADOOP-11867?focusedWorklogId=486468&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-486468
]
ASF GitHub Bot logged work on HADOOP-11867:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Sep/20 03:32
Start Date: 19/Sep/20 03:32
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #1830:
URL: https://github.com/apache/hadoop/pull/1830#issuecomment-695157853
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 28s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 3m 18s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 30m 6s | trunk passed |
| +1 :green_heart: | compile | 24m 14s | trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | compile | 19m 42s | trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | checkstyle | 1m 2s | trunk passed |
| +1 :green_heart: | mvnsite | 3m 36s | trunk passed |
| +1 :green_heart: | shadedclient | 20m 46s | branch has no errors when
building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 1m 29s | trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 3m 23s | trunk passed with JDK Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +0 :ok: | spotbugs | 2m 30s | Used deprecated FindBugs config;
considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 6m 33s | trunk passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 9s | benchmark in the patch failed. |
| +1 :green_heart: | compile | 23m 24s | the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javac | 23m 24s | the patch passed |
| +1 :green_heart: | compile | 19m 43s | the patch passed with JDK
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | javac | 19m 43s | the patch passed |
| -0 :warning: | checkstyle | 1m 0s | hadoop-common-project: The patch
generated 29 new + 93 unchanged - 1 fixed = 122 total (was 94) |
| -1 :x: | mvnsite | 0m 23s | benchmark in the patch failed. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | shadedclient | 16m 4s | patch has no errors when
building and testing our client artifacts. |
| -1 :x: | javadoc | 0m 23s | benchmark in the patch failed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1. |
| -1 :x: | javadoc | 0m 22s | benchmark in the patch failed with JDK
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01. |
| -1 :x: | findbugs | 2m 45s | hadoop-common-project/hadoop-common
generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| -1 :x: | findbugs | 4m 18s | hadoop-common-project generated 1 new +
0 unchanged - 0 fixed = 1 total (was 0) |
| -1 :x: | findbugs | 0m 22s | benchmark in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 10m 16s | hadoop-common in the patch passed.
|
| -1 :x: | unit | 17m 33s | hadoop-common-project in the patch passed. |
| -1 :x: | unit | 0m 23s | benchmark in the patch failed. |
| +1 :green_heart: | asflicense | 0m 49s | The patch does not generate
ASF License warnings. |
| | | 223m 59s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Result of integer multiplication cast to long in
org.apache.hadoop.fs.ChecksumFileSystem$ChecksumFSInputChecker.checkBytes(ByteBuffer,
long, ByteBuffer, long, int, Path) At ChecksumFileSystem.java:to long in
org.apache.hadoop.fs.ChecksumFileSystem$ChecksumFSInputChecker.checkBytes(ByteBuffer,
long, ByteBuffer, long, int, Path) At ChecksumFileSystem.java:[line 353] |
| FindBugs | module:hadoop-common-project |
| | Result of integer multiplication cast to long in
org.apache.hadoop.fs.ChecksumFileSystem$ChecksumFSInputChecker.checkBytes(ByteBuffer,
long, ByteBuffer, long, int, Path) At ChecksumFileSystem.java:to long in
org.apache.hadoop.fs.ChecksumFileSystem$ChecksumFSInputChecker.checkBytes(ByteBuffer,
long, ByteBuffer, long, int, Path) At ChecksumFileSystem.java:[line 353] |
| Failed junit tests | hadoop.crypto.key.kms.server.TestKMS |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1830/6/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1830 |
| JIRA Issue | HADOOP-11867 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml findbugs checkstyle |
| uname | Linux 4bd781809682 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / fc2435cb5cf |
| Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| mvninstall |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1830/6/artifact/out/patch-mvninstall-hadoop-common-project_benchmark.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1830/6/artifact/out/diff-checkstyle-hadoop-common-project.txt
|
| mvnsite |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1830/6/artifact/out/patch-mvnsite-hadoop-common-project_benchmark.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1830/6/artifact/out/patch-javadoc-hadoop-common-project_benchmark-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1830/6/artifact/out/patch-javadoc-hadoop-common-project_benchmark-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt
|
| findbugs |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1830/6/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html
|
| findbugs |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1830/6/artifact/out/new-findbugs-hadoop-common-project.html
|
| findbugs |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1830/6/artifact/out/patch-findbugs-hadoop-common-project_benchmark.txt
|
| unit |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1830/6/artifact/out/patch-unit-hadoop-common-project.txt
|
| unit |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1830/6/artifact/out/patch-unit-hadoop-common-project_benchmark.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1830/6/testReport/ |
| Max. process+thread count | 2738 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-common-project
hadoop-common-project/benchmark U: hadoop-common-project |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1830/6/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 486468)
Remaining Estimate: 0h
Time Spent: 10m
> FS API: Add a high-performance vectored Read to FSDataInputStream API
> ---------------------------------------------------------------------
>
> Key: HADOOP-11867
> URL: https://issues.apache.org/jira/browse/HADOOP-11867
> Project: Hadoop Common
> Issue Type: New Feature
> Components: fs, fs/azure, fs/s3, hdfs-client
> Affects Versions: 3.0.0
> Reporter: Gopal Vijayaraghavan
> Assignee: Owen O'Malley
> Priority: Major
> Labels: performance
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The most significant way to read from a filesystem in an efficient way is to
> let the FileSystem implementation handle the seek behaviour underneath the
> API to be the most efficient as possible.
> A better approach to the seek problem is to provide a sequence of read
> locations as part of a single call, while letting the system schedule/plan
> the reads ahead of time.
> This is exceedingly useful for seek-heavy readers on HDFS, since this allows
> for potentially optimizing away the seek-gaps within the FSDataInputStream
> implementation.
> For seek+read systems with even more latency than locally-attached disks,
> something like a {{readFully(long[] offsets, ByteBuffer[] chunks)}} would
> take of the seeks internally while reading chunk.remaining() bytes into each
> chunk (which may be {{slice()}}ed off a bigger buffer).
> The base implementation can stub in this as a sequence of seeks + read() into
> ByteBuffers, without forcing each FS implementation to override this in any
> way.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
