liuml07 commented on a change in pull request #2189:
URL: https://github.com/apache/hadoop/pull/2189#discussion_r491859739



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestBlockStatsMXBean.java
##########
@@ -145,9 +150,11 @@ public void testStorageTypeStatsJMX() throws Exception {
       Map<String,Object> storageTypeStats = 
(Map<String,Object>)entry.get("value");
       typesPresent.add(storageType);
       if (storageType.equals("ARCHIVE") || storageType.equals("DISK") ) {
-        assertEquals(3l, storageTypeStats.get("nodesInService"));
+        assertEquals(3L, storageTypeStats.get("nodesInService"));

Review comment:
       Hadoop releases before 2.10 are all end of life (EoL). Hadoop 2.10 is 
the only version using Java 7. We do not need any support, compile or runtime, 
for Java versions before Java 7.
   
   Hadoop 3.x are all using Java 8+. We do not need any Java 7 support in 
Hadoop 3.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to