[ https://issues.apache.org/jira/browse/HADOOP-11452?focusedWorklogId=487733&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-487733 ]
ASF GitHub Bot logged work on HADOOP-11452: ------------------------------------------- Author: ASF GitHub Bot Created on: 22/Sep/20 03:31 Start Date: 22/Sep/20 03:31 Worklog Time Spent: 10m Work Description: hadoop-yetus removed a comment on pull request #743: URL: https://github.com/apache/hadoop/pull/743#issuecomment-689849388 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 10 new or modified test files. | ||| _ trunk Compile Tests _ | | +0 :ok: | mvndep | 3m 26s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 30m 11s | trunk passed | | +1 :green_heart: | compile | 23m 30s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | -1 :x: | compile | 0m 35s | root in trunk failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01. | | -0 :warning: | checkstyle | 0m 22s | The patch fails to run checkstyle in root | | -1 :x: | mvnsite | 0m 29s | hadoop-common in trunk failed. | | -1 :x: | mvnsite | 0m 34s | hadoop-hdfs in trunk failed. | | -1 :x: | mvnsite | 0m 29s | hadoop-hdfs-client in trunk failed. | | -1 :x: | mvnsite | 0m 35s | hadoop-aws in trunk failed. | | -1 :x: | shadedclient | 12m 52s | branch has errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 4m 6s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | +1 :green_heart: | javadoc | 5m 41s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | +0 :ok: | spotbugs | 0m 53s | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 :green_heart: | findbugs | 12m 7s | trunk passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 23s | the patch passed | | -1 :x: | compile | 15m 11s | root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1. | | -1 :x: | javac | 15m 11s | root in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1. | | -1 :x: | compile | 0m 27s | root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01. | | -1 :x: | javac | 0m 27s | root in the patch failed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01. | | -0 :warning: | checkstyle | 3m 8s | root: The patch generated 587 new + 0 unchanged - 0 fixed = 587 total (was 0) | | +1 :green_heart: | mvnsite | 4m 43s | the patch passed | | -1 :x: | whitespace | 0m 0s | The patch has 8 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply | | +1 :green_heart: | shadedclient | 14m 15s | patch has no errors when building and testing our client artifacts. | | +1 :green_heart: | javadoc | 2m 31s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 | | -1 :x: | javadoc | 1m 20s | hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 generated 3 new + 1 unchanged - 0 fixed = 4 total (was 1) | | -1 :x: | findbugs | 2m 15s | hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | -1 :x: | unit | 9m 24s | hadoop-common in the patch passed. | | +1 :green_heart: | unit | 2m 3s | hadoop-hdfs-client in the patch passed. | | -1 :x: | unit | 96m 17s | hadoop-hdfs in the patch passed. | | +1 :green_heart: | unit | 0m 33s | hadoop-openstack in the patch passed. | | +1 :green_heart: | unit | 1m 24s | hadoop-aws in the patch passed. | | +1 :green_heart: | asflicense | 0m 48s | The patch does not generate ASF License warnings. | | | | 267m 36s | | | Reason | Tests | |-------:|:------| | FindBugs | module:hadoop-common-project/hadoop-common | | | Should org.apache.hadoop.fs.impl.RenameHelper$RenameValidationResult be a _static_ inner class? At RenameHelper.java:inner class? At RenameHelper.java:[line 320] | | Failed junit tests | hadoop.fs.contract.rawlocal.TestRawlocalContractRenameEx | | | hadoop.fs.viewfs.TestFcMainOperationsLocalFs | | | hadoop.fs.TestSymlinkLocalFSFileSystem | | | hadoop.fs.TestTrash | | | hadoop.fs.TestFSMainOperationsLocalFileSystem | | | hadoop.fs.viewfs.TestViewFsWithAuthorityLocalFs | | | hadoop.fs.viewfs.TestViewFsLocalFs | | | hadoop.fs.viewfs.TestViewFsTrash | | | hadoop.fs.viewfs.TestChRootedFs | | | hadoop.fs.contract.localfs.TestLocalFSContractRenameEx | | | hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem | | | hadoop.fs.TestChecksumFs | | | hadoop.fs.TestLocalFSFileContextMainOperations | | | hadoop.fs.TestLocalFSFileContextCreateMkdir | | | hadoop.fs.viewfs.TestFcCreateMkdirLocalFs | | | hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem | | | hadoop.fs.TestSymlinkLocalFSFileContext | | | hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem | | | hadoop.hdfs.server.namenode.TestCreateEditsLog | | | hadoop.hdfs.TestFileChecksum | | | hadoop.fs.contract.hdfs.TestHDFSContractRename | | | hadoop.hdfs.TestStripedFileAppend | | | hadoop.hdfs.TestFileChecksumCompositeCrc | | | hadoop.hdfs.server.datanode.TestBPOfferService | | | hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier | | | hadoop.hdfs.TestHDFSTrash | | | hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped | | | hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics | | | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/743 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle markdownlint | | uname | Linux a3de12066332 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / e5fe3262702 | | Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 | | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/branch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt | | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/buildtool-branch-checkstyle-root.txt | | mvnsite | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/branch-mvnsite-hadoop-common-project_hadoop-common.txt | | mvnsite | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt | | mvnsite | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt | | mvnsite | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/branch-mvnsite-hadoop-tools_hadoop-aws.txt | | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt | | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/patch-compile-root-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt | | compile | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt | | javac | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt | | checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/diff-checkstyle-root.txt | | whitespace | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/whitespace-eol.txt | | javadoc | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/diff-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkPrivateBuild-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01.txt | | findbugs | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html | | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt | | unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/testReport/ | | Max. process+thread count | 4168 (vs. ulimit of 5500) | | modules | C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-openstack hadoop-tools/hadoop-aws U: . | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-743/5/console | | versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 | | Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 487733) Time Spent: 2h 40m (was: 2.5h) > Make FileSystem.rename(path, path, options) public, specified, tested > --------------------------------------------------------------------- > > Key: HADOOP-11452 > URL: https://issues.apache.org/jira/browse/HADOOP-11452 > Project: Hadoop Common > Issue Type: Task > Components: fs > Affects Versions: 2.7.3 > Reporter: Yi Liu > Assignee: Steve Loughran > Priority: Major > Labels: pull-request-available > Attachments: HADOOP-11452-001.patch, HADOOP-11452-002.patch, > HADOOP-14452-004.patch, HADOOP-14452-branch-2-003.patch > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Currently in {{FileSystem}}, {{rename}} with _Rename options_ is protected > and with _deprecated_ annotation. And the default implementation is not > atomic. > So this method is not able to be used outside. On the other hand, HDFS has a > good and atomic implementation. (Also an interesting thing in {{DFSClient}}, > the _deprecated_ annotations for these two methods are opposite). > It makes sense to make public for {{rename}} with _Rename options_, since > it's atomic for rename+overwrite, also it saves RPC calls if user desires > rename+overwrite. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org