klcopp commented on a change in pull request #2321:
URL: https://github.com/apache/hadoop/pull/2321#discussion_r492695507
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
##########
@@ -632,9 +635,21 @@ public static void closeAll() throws IOException {
*/
public static void closeAllForUGI(UserGroupInformation ugi)
throws IOException {
+ if (LOGGER.isDebugEnabled()) {
+ debugLogFileSystemClose("closeAllForUGI", "UGI: " + ugi.toString());
+ }
CACHE.closeAll(ugi);
}
+ private static void debugLogFileSystemClose(String methodName, String
additionalInfo) {
+ StackTraceElement callingMethod = new
Throwable().fillInStackTrace().getStackTrace()[2];
+ LOGGER.debug(
+ "FileSystem." + methodName + "() called by method: "
Review comment:
Hi Steve, thanks for taking a look at this!
Could you clarify what you mean by this?: You might want to think that at
TRACE the entire throwable is logged. Why so? one level up isn't always enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
