bshashikant commented on pull request #2326: URL: https://github.com/apache/hadoop/pull/2326#issuecomment-697152099
> How about failing the second user delete request with a "Already marked as deleted" exception instead of changing the edit log loading? It is hard for editlog loading to guess if the command is valid. Thanks @szetszwo . The problem is just not with user deletes. Let's see a sequence like this: 1) Let's say we have 2 snapshots s1 and S2 after enabling ordered snapshot deletion 2) User deleted S2 ---> creates an edit log entry 3) User deleted S1 4) Snapshot Deletion GC thread will now delete S2 ---> creates an edit log entry again 5) Now turn off Ordered Snapshot Deletion and Restart It will run into the same problem again. We cannot seem to avoid 2 edit log entries for same snapshot delete with Snapshot GC thread running and deleting the snapshot. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
