[
https://issues.apache.org/jira/browse/HADOOP-16848?focusedWorklogId=490089&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-490089
]
ASF GitHub Bot logged work on HADOOP-16848:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Sep/20 09:24
Start Date: 24/Sep/20 09:24
Worklog Time Spent: 10m
Work Description: hadoop-yetus removed a comment on pull request #1839:
URL: https://github.com/apache/hadoop/pull/1839#issuecomment-697596737
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 25s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | | 0m 0s | [test4tests](test4tests) | The patch
appears to include 4 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 3m 21s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 30m 57s | | trunk passed |
| +1 :green_heart: | compile | 24m 28s | | trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | compile | 20m 37s | | trunk passed with JDK
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | checkstyle | 3m 8s | | trunk passed |
| +1 :green_heart: | mvnsite | 2m 16s | | trunk passed |
| +1 :green_heart: | shadedclient | 23m 10s | | branch has no errors
when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 55s | | trunk passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 2m 4s | | trunk passed with JDK
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +0 :ok: | spotbugs | 1m 22s | | Used deprecated FindBugs config;
considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 3m 54s | | trunk passed |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 27s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 33s | | the patch passed |
| +1 :green_heart: | compile | 23m 26s | | the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javac | 23m 26s | | the patch passed |
| +1 :green_heart: | compile | 20m 0s | | the patch passed with JDK
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | javac | 20m 0s | | the patch passed |
| -0 :warning: | checkstyle | 2m 56s |
[/diff-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1839/2/artifact/out/diff-checkstyle-root.txt)
| root: The patch generated 33 new + 43 unchanged - 0 fixed = 76 total (was
43) |
| +1 :green_heart: | mvnsite | 2m 6s | | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | | The patch has no
whitespace issues. |
| +1 :green_heart: | shadedclient | 16m 0s | | patch has no errors
when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 53s | | the patch passed with JDK
Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 2m 21s | | the patch passed with JDK
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| -1 :x: | findbugs | 1m 29s |
[/new-findbugs-hadoop-tools_hadoop-aws.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1839/2/artifact/out/new-findbugs-hadoop-tools_hadoop-aws.html)
| hadoop-tools/hadoop-aws generated 7 new + 0 unchanged - 0 fixed = 7 total
(was 0) |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 10m 3s | | hadoop-common in the patch
passed. |
| -1 :x: | unit | 1m 28s |
[/patch-unit-hadoop-tools_hadoop-aws.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1839/2/artifact/out/patch-unit-hadoop-tools_hadoop-aws.txt)
| hadoop-aws in the patch passed. |
| +1 :green_heart: | asflicense | 0m 50s | | The patch does not
generate ASF License warnings. |
| | | 200m 45s | | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-tools/hadoop-aws |
| | Dead store to launch in
org.apache.hadoop.fs.s3a.S3AFileSystem.asyncLaunchStore() At
S3AFileSystem.java:org.apache.hadoop.fs.s3a.S3AFileSystem.asyncLaunchStore()
At S3AFileSystem.java:[line 4819] |
| | Inconsistent synchronization of
org.apache.hadoop.fs.s3a.S3AFileSystem.signerManager; locked 66% of time
Unsynchronized access at S3AFileSystem.java:66% of time Unsynchronized access
at S3AFileSystem.java:[line 4791] |
| | Unread field:S3AStoreImpl.java:[line 64] |
| | Unread field:S3AStoreImpl.java:[line 65] |
| | Unread field:S3AStoreImpl.java:[line 61] |
| | Unread field:S3AStoreImpl.java:[line 62] |
| | Unread field:S3AStoreImpl.java:[line 63] |
| Failed junit tests |
hadoop.fs.s3a.commit.staging.TestStagingPartitionedTaskCommit |
| | hadoop.fs.s3a.TestS3AUnbuffer |
| | hadoop.fs.s3a.commit.staging.TestStagingPartitionedJobCommit |
| | hadoop.fs.s3a.TestListing |
| | hadoop.fs.s3a.commit.staging.TestStagingCommitter |
| | hadoop.fs.s3a.TestS3AGetFileStatus |
| | hadoop.fs.s3a.commit.staging.TestDirectoryCommitterScale |
| | hadoop.fs.s3a.TestS3ABlockOutputStream |
| | hadoop.fs.s3a.commit.staging.TestStagingDirectoryOutputCommitter |
| | hadoop.fs.s3a.s3guard.TestObjectChangeDetectionAttributes |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1839/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1839 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux e206b2b01b60 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 18f9d77c46f |
| Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1839/2/testReport/ |
| Max. process+thread count | 3233 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws
U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-1839/2/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 490089)
Time Spent: 40m (was: 0.5h)
> add initial S3A layering + async init
> -------------------------------------
>
> Key: HADOOP-16848
> URL: https://issues.apache.org/jira/browse/HADOOP-16848
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Split the S3A code into layers
> * S3AFileSystem
> * S3AStore + Impl
> * RawS3A + Impl
> S3AFS will create the others and start in order: DelegationTokens, RawS3A,
> S3AStore, Metastore
> this will involve wrapping all access of DTs, s3client, Metastore to block
> until that layer is complete, or raise an exception if instantiation of
> it/predecessor failed.
> New layers will all be subclasses of Service, split into Interface and Impl,
> so we can manage the init/start/stop lifecycle with existing code
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
