viirya commented on a change in pull request #2297:
URL: https://github.com/apache/hadoop/pull/2297#discussion_r494542249
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java
##########
@@ -432,7 +412,11 @@ public void assertCompression(String name, Compressor
compressor,
joiner.join(name, "byte arrays not equals error !!!"),
originalRawData, decompressOut.toByteArray());
} catch (Exception ex) {
- fail(joiner.join(name, ex.getMessage()));
+ if (ex.getMessage() != null) {
+ fail(joiner.join(name, ex.getMessage()));
+ } else {
+ fail(joiner.join(name, ExceptionUtils.getStackTrace(ex)));
Review comment:
When I first took over this change, the test failed with NPE without any
details. It is because the exception thrown returns null from `getMessage()`.
`joiner.join(name, null)` causes the NPE, so I changed it to print stack trace
once `getMessage()` returns null. It's better for debugging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
