ferhui commented on a change in pull request #2327:
URL: https://github.com/apache/hadoop/pull/2327#discussion_r495517635
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallerContext.java
##########
@@ -108,24 +117,86 @@ public String toString() {
}
/** The caller context builder. */
- public static final class Builder {
- private final String context;
+ public static final class Builder implements Configurable {
Review comment:
Great suggestions!
>Add a new method public append(String key, String value) which calls
> sb.append(key).append(separator).append(value)
For example, maybe context contains multi items and it is
"mr_xxxx,ip:a.b.c.d", here item separator is ',' and key/value separator is
':', the separator we define is item separator. should we add method public
append(String key, String value, separator)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
