liuml07 commented on pull request #2321: URL: https://github.com/apache/hadoop/pull/2321#issuecomment-700192324
> add the minimum amount of cost possible. How leaving `if (LOGGER.isDebugEnabled())` out of `debugLogFileSystemClose()` do that? Saving one function call? I do not assume that is a concern. I'm more concerned if people forget to check that when calling the method, so make it in the function is preferred to me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
