[
https://issues.apache.org/jira/browse/HADOOP-17267?focusedWorklogId=492099&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-492099
]
ASF GitHub Bot logged work on HADOOP-17267:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/20 18:02
Start Date: 28/Sep/20 18:02
Worklog Time Spent: 10m
Work Description: liuml07 edited a comment on pull request #2321:
URL: https://github.com/apache/hadoop/pull/2321#issuecomment-700192324
> add the minimum amount of cost possible.
How leaving `if (LOGGER.isDebugEnabled())` out of
`debugLogFileSystemClose()` do that? Saving one function call? I do not assume
that is a concern. I'm more concerned if people forget to check that when
calling the method, so to me putting the check in the function is preferred.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 492099)
Time Spent: 4.5h (was: 4h 20m)
> Add debug-level logs in Filesystem#close
> ----------------------------------------
>
> Key: HADOOP-17267
> URL: https://issues.apache.org/jira/browse/HADOOP-17267
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 3.3.0
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> HDFS reuses the same cached FileSystem object across the file system. If the
> client calls FileSystem.close(), closeAllForUgi(), or closeAll() (if it
> applies to the instance) anywhere in the system it purges the cache of that
> FS instance, and trying to use the instance results in an IOException:
> FileSystem closed.
> It would be a great help to clients to see where and when a given FS instance
> was closed. I.e. in close(), closeAllForUgi(), or closeAll(), it would be
> great to see a DEBUG-level log of
> * calling method name, class, file name/line number
> * FileSystem object's identity hash (FileSystem.close() only)
> For the full calling stack, turn on TRACE logging.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
