dbtsai commented on a change in pull request #2350:
URL: https://github.com/apache/hadoop/pull/2350#discussion_r496999926
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/lz4/Lz4Compressor.java
##########
@@ -236,7 +237,7 @@ public synchronized int compress(byte[] b, int off, int len)
}
// Compress data
- n = useLz4HC ? compressBytesDirectHC() : compressBytesDirect();
+ n = compressBytesDirect();
Review comment:
`compressDirectBuf`?
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java
##########
@@ -494,8 +494,7 @@ public String getName() {
private static <T extends Compressor, E extends Decompressor> boolean
isAvailable(TesterPair<T, E> pair) {
Compressor compressor = pair.compressor;
- if (compressor.getClass().isAssignableFrom(Lz4Compressor.class)
- && (NativeCodeLoader.isNativeCodeLoaded()))
+ if (compressor.getClass().isAssignableFrom(Lz4Compressor.class))
Review comment:
Can we add a compatibility test like snappy?
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
##########
@@ -143,22 +143,16 @@ public void testSnappyCodec() throws IOException {
@Test
public void testLz4Codec() throws IOException {
- if (NativeCodeLoader.isNativeCodeLoaded()) {
- if (Lz4Codec.isNativeCodeLoaded()) {
- conf.setBoolean(
+ conf.setBoolean(
CommonConfigurationKeys.IO_COMPRESSION_CODEC_LZ4_USELZ4HC_KEY,
Review comment:
indentation as you remove the `{ }`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
