[
https://issues.apache.org/jira/browse/HADOOP-17295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chen Zhi updated HADOOP-17295:
------------------------------
Description:
I find some cases where some pre-processing statements dedicated to logging
calls are not guarded by existing logging guards. Most of them are easy to fix.
And the performance and maintainability of these logging calls can be improved
to some extend. So I create a PR to fix them.
These issues are detected by a static analysis tool wrote by myself. This tool
can extract all the dedicated statements for each debug-logging calls (i.e.,
the results of these statements are only used by debug-logging calls). Because
I realize that debug logs will incur overhead in production, such as string
concatenation and method calls in the parameters of logging calls as well as
pre-processing statements. And I want to perform a systematic evaluation for
the overhead of debugging logging calls in production.
was:
I find some cases where some pre-processing statements dedicated to logging
calls are not guarded by existing logging guards. Most of them are easy to fix.
And I create a PR to fix them.
These issues are detected by a static analysis tool wrote by myself. This tool
can extract all the dedicated statements for each debug-logging calls (i.e.,
the results of these statements are only used by debug-logging calls). Because
I realize that debug logs will incur overhead in production, such as string
concatenation and method calls in the parameters of logging calls as well as
pre-processing statements. And I want to perform a systematic evaluation for
the overhead of debugging logging calls in production.
> Move dedicated pre-logging statements into existing logging guards
> ------------------------------------------------------------------
>
> Key: HADOOP-17295
> URL: https://issues.apache.org/jira/browse/HADOOP-17295
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Chen Zhi
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I find some cases where some pre-processing statements dedicated to logging
> calls are not guarded by existing logging guards. Most of them are easy to
> fix. And the performance and maintainability of these logging calls can be
> improved to some extend. So I create a PR to fix them.
> These issues are detected by a static analysis tool wrote by myself. This
> tool can extract all the dedicated statements for each debug-logging calls
> (i.e., the results of these statements are only used by debug-logging calls).
> Because I realize that debug logs will incur overhead in production, such as
> string concatenation and method calls in the parameters of logging calls as
> well as pre-processing statements. And I want to perform a systematic
> evaluation for the overhead of debugging logging calls in production.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
