bilaharith commented on pull request #2278:
URL: https://github.com/apache/hadoop/pull/2278#issuecomment-703294541


   > -1 as is
   > 
   > I would like azure-auth-keys.xml to continue to be supported unless there 
is a very good reason not to
   > 
   > I am permanently switching to different branches with different hadoop 
versions on, and if different releases change their test run config/process, 
then things stop working.
   > 
   > If you have a good reason to change the name of the test file other than 
"I didn't think the name was sufficient", then please state it.
   > 
   > Thanks
   > 
   > Also : move the scripts to dev-support
   
   We planned this rename so that the same is known to the hadoop-azure 
developers that it is required to follow the template file and add all those 
configs as part of the configs file. This ensures uniformity among the test 
results across all the developers. This ensures better code coverage and helps 
bubbling up in case any regression is introduced as part of the code change. 
Currently the configs differ for most of us. Recently some test case failure 
got caught with a developer who was running the tests with sharedkey. The same 
was missed for those who used OAuth. We also would like to make it madatory to 
publish the test results for 3 main scenarios which is added in the runtests.sh 
so that the aforementioned situations can be avoided in the future.
   
   I have moved the script under dev-support.
   Let me know if you have more comments on this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to