[
https://issues.apache.org/jira/browse/HADOOP-7693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117522#comment-13117522
]
Aaron T. Myers commented on HADOOP-7693:
----------------------------------------
+1, the patch looks good to me.
One tiny nit: You might consider putting a space after the "," in your generic
type declarations, e.g.:
{code}
private Map<String,Responder> responders = new HashMap<String,Responder>();
{code}
> fix RPC.Server#addProtocol to work in AvroRpcEngine
> ---------------------------------------------------
>
> Key: HADOOP-7693
> URL: https://issues.apache.org/jira/browse/HADOOP-7693
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Attachments: HADOOP-7693.patch, HADOOP-7693.patch
>
>
> HADOOP-7524 introduced a new way of passing protocols to RPC servers, but it
> was not implemented correctly by AvroRpcEngine in that issue. This is
> required to fix HDFS-2298.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
