[ 
https://issues.apache.org/jira/browse/HADOOP-17272?focusedWorklogId=496300&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496300
 ]

ASF GitHub Bot logged work on HADOOP-17272:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Oct/20 05:17
            Start Date: 07/Oct/20 05:17
    Worklog Time Spent: 10m 
      Work Description: mehakmeet commented on a change in pull request #2353:
URL: https://github.com/apache/hadoop/pull/2353#discussion_r500742812



##########
File path: 
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsInputStreamStatistics.java
##########
@@ -160,7 +159,7 @@ public void testSeekStatistics() throws IOException {
       assertEquals("Mismatch in forwardSeekOps value", OPERATIONS,
           stats.getForwardSeekOperations());
       assertEquals("Mismatch in bytesBackwardsOnSeek value",
-          -1 * OPERATIONS * ONE_MB, stats.getBytesBackwardsOnSeek());
+          OPERATIONS * ONE_MB, stats.getNegativeBytesBackwardsOnSeek());

Review comment:
       bytesBackwardsOnSeek had negative increments and thus had a negative 
value but, since we have a restriction that counters can't increment negative 
values, I thought to have a negative of bytesBackwardsOnSeek counter so that we 
can have a counter to represent this value just in positive. Looks confusing I 
guess, should've come up with better naming :)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 496300)
    Time Spent: 1h 20m  (was: 1h 10m)

> ABFS Streams to  support IOStatistics API
> -----------------------------------------
>
>                 Key: HADOOP-17272
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17272
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/azure
>    Affects Versions: 3.3.1
>            Reporter: Steve Loughran
>            Assignee: Mehakmeet Singh
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> ABFS input/output streams to support IOStatistics API



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to