coder-chenzhi commented on a change in pull request #2358:
URL: https://github.com/apache/hadoop/pull/2358#discussion_r500992285



##########
File path: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/DefaultContainerExecutor.java
##########
@@ -566,11 +566,10 @@ public void writeLocalWrapperScript(Path launchDst, Path 
pidFile,
   @Override
   public boolean signalContainer(ContainerSignalContext ctx)
       throws IOException {
-    String user = ctx.getUser();
     String pid = ctx.getPid();
     Signal signal = ctx.getSignal();
     LOG.debug("Sending signal {} to pid {} as user {}",

Review comment:
       Sorry for my mistake. I  did not notice that developer has changed this 
logging call to parameterized logging and removed the logging guard.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to