[ 
https://issues.apache.org/jira/browse/HADOOP-7035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117742#comment-13117742
 ] 

Konstantin Shvachko commented on HADOOP-7035:
---------------------------------------------

Sounds like a good approach to me. I see SigTest does some thorough analysis of 
the APIs compared to JDiff.
# Is it possible that the tool needs to be applied the other way around, that 
is having 0.22 as the base and Tested version being 0.21?
A was looking into the history of Class org.apache.hadoop.io.MapFile$Reader. 
The tool says
{code}
  "E1.2 - API type removed" : method protected 
org.apache.hadoop.io.SequenceFile$Reader 
org.apache.hadoop.io.MapFile$Reader.createDataFileReader(org.apache.hadoop.fs.FileSystem,org.apache.hadoop.fs.Path,org.apache.hadoop.conf.Configuration)
{code}
But its seems createDataFileReader() has been added in 0.22. Or am I missing 
something?
# Did you run the tool against MR only? Hard to believe there were no API 
changes in HDFS and common.
# What is the final goal of this jira. Is it to identify incompatible changes 
and make a patch for site with the release notes?
If so we can filter out non public changes from the reports generated by 
SigTest and probably those that do not belong to public APIs in turns of Hadoop 
annotations, if it makes sense.
# I think for 0.22 we can restrict ourselves to comparing with 0.21 only. Or do 
people think we need comparisons with 0.20.* (how many of them?)?
                
> Document incompatible API changes between releases
> --------------------------------------------------
>
>                 Key: HADOOP-7035
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7035
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Tom White
>            Assignee: Tom White
>            Priority: Blocker
>             Fix For: 0.22.0
>
>         Attachments: apicheck-hadoop-0.20.203.0-0.20.204.0.txt, 
> apicheck-hadoop-0.21.0-0.22.0-SNAPSHOT.txt, jdiff-with-previous-release.sh, 
> jdiff-with-previous-release.sh
>
>
> We can use JDiff to generate a list of incompatible changes for each release. 
> See 
> https://issues.apache.org/jira/browse/HADOOP-6668?focusedCommentId=12860017&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12860017

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to