saintstack commented on a change in pull request #2342:
URL: https://github.com/apache/hadoop/pull/2342#discussion_r501216538
##########
File path: hadoop-common-project/hadoop-auth/pom.xml
##########
@@ -234,6 +235,24 @@
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
</configuration>
</plugin>
+ <plugin>
+ <groupId>com.google.code.maven-replacer-plugin</groupId>
+ <artifactId>replacer</artifactId>
+ <executions>
+ <execution>
+ <id>replace-sources</id>
+ <configuration>
+ <skip>false</skip>
+ </configuration>
+ </execution>
+ <execution>
+ <id>replace-test-sources</id>
+ <configuration>
+ <skip>false</skip>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review comment:
A few questions so I can better understand the suggested approach:
So source would continue to refer to unshaded guava? (unshaded guava 11?)
Rather than rewrite once as this PR does, we'd rewrite on every build? How
long does the rewrite take?
hadoop-yarn-csi is bound to guava-20? Why is that? The grpc used? Interested
in how a guava 20 in classpath won't mess up downstreamers who want to use
something newer (or older).
For 4., hopefully we can (later) add an enforcer so non-shaded references
get flagged at build time. Rather than have hadoop depend on something it
doesn't use, hopefully we can work on fixing the curator dependency to fix its
pom?
Thanks @vinayakumarb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
