steveloughran commented on a change in pull request #2375:
URL: https://github.com/apache/hadoop/pull/2375#discussion_r502537425
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/fs/contract/router/web/TestRouterWebHDFSContractRootDirectory.java
##########
@@ -71,4 +71,9 @@ public void testRmRootRecursive() {
public void testRmEmptyRootDirRecursive() {
// It doesn't apply because we still have the mount points here
}
+
+ @Override
+ public void testSimpleRootListing() {
+ // It doesn't apply because DFSRouter dosn't support LISTSTATUS_BATCH.
Review comment:
prefer an `Assume.assumeTrue(unsupported, false)` so it goes into the
skipped stats. But, given the rest of the tests are the same, not much of an
issue.
##########
File path: hadoop-hdfs-project/hadoop-hdfs-rbf/pom.xml
##########
@@ -114,6 +114,11 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";>
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
Review comment:
assertj is already exported in test scope for hadoop-common. I'd have
expected it to be picked up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
