[
https://issues.apache.org/jira/browse/HADOOP-7703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118335#comment-13118335
]
Hadoop QA commented on HADOOP-7703:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12497166/HADOOP-7703.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/249//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/249//console
This message is automatically generated.
> WebAppContext should also be stopped and cleared
> ------------------------------------------------
>
> Key: HADOOP-7703
> URL: https://issues.apache.org/jira/browse/HADOOP-7703
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.24.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.24.0
>
> Attachments: HADOOP-7703.patch
>
>
> 1. If listener stop method throws any exception then the webserver stop
> method will not be called
> {code}
> public void stop() throws Exception {
> listener.close();
> webServer.stop();
> }
> {code}
> 2. also, WebAppContext stores all the context attributes, which does not get
> cleared if only webServer is stopped.
> so following calls are necessary to ensure clean and complete stop.
> {code}
> webAppContext.clearAttributes();
> webAppContext.stop();
> {code}
> 3. Also the WebAppContext display name can be the name passed to HttpServer
> instance.
> {code}
> webAppContext.setDisplayName(name);
> {code}
> instead of
> {code}
> webAppContext.setDisplayName("WepAppsContext");
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
