Jing9 commented on pull request #2288: URL: https://github.com/apache/hadoop/pull/2288#issuecomment-713921549
Thanks for working on this, Leon! The patch looks good to me in general. Still have a couple of questions for discussion: 1. To add percentage and mount in FsVolumeImpl may not be very clear. How about we add a new wrapper class for the group of volumes and indicating their common mount and capacity distribution? 2. "reserved" is shared by the FsVolumeImpl instances on the same mount. Thus we need to verify if the reserved space of the mount may be counted twice. 3. Later update of the DFS_DATANODE_RESERVE_FOR_ARCHIVE_PERCENTAGE configuration may affect the capacity usage percentage calculation, although this scenario is rare in practice. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
