[
https://issues.apache.org/jira/browse/HADOOP-17244?focusedWorklogId=503715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-503715
]
ASF GitHub Bot logged work on HADOOP-17244:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/20 12:56
Start Date: 22/Oct/20 12:56
Worklog Time Spent: 10m
Work Description: steveloughran commented on pull request #2310:
URL: https://github.com/apache/hadoop/pull/2310#issuecomment-714475083
Checkstyle still fussy. What a pain
```
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:93:
"Bulk delete operation failed to delete all objects; failure count =
{}",: Line is longer than 80 characters (found 81). [LineLength]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:331:
List<KeyPath> undeleted = extractUndeletedKeyPaths(deleteException,
qualifier);: Line is longer than 80 characters (found 83). [LineLength]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:360:
public final String key;:25: Variable 'key' must be private and have
accessor methods. [VisibilityModifier]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:361:
public final Path path;:23: Variable 'path' must be private and have
accessor methods. [VisibilityModifier]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:362:
public final boolean directoryMarker;:26: Variable 'directoryMarker' must
be private and have accessor methods. [VisibilityModifier]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:398:
if (this == o) { return true; }:22: '{' at column 22 should have line
break after. [LeftCurly]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MultiObjectDeleteSupport.java:399:
if (o == null || getClass() != o.getClass()) { return false; }:52: '{' at
column 52 should have line break after. [LeftCurly]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestPartialRenamesDeletes.java:668:
MetricDiff deleteObjectCount = new MetricDiff(roleFS,
OBJECT_DELETE_OBJECTS);: Line is longer than 80 characters (found 81).
[LineLength]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/ITestPartialRenamesDeletes.java:676:
deleteObjectCount.assertDiffEquals("Wrong count of objects in delete
request",: Line is longer than 80 characters (found 84). [LineLength]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 503715)
Time Spent: 4h (was: 3h 50m)
> HADOOP-17244. S3A directory delete tombstones dir markers prematurely.
> ----------------------------------------------------------------------
>
> Key: HADOOP-17244
> URL: https://issues.apache.org/jira/browse/HADOOP-17244
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 3.3.1
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Test failure:
> {{ITestS3AFileContextMainOperations#testRenameDirectoryAsNonExistentDirectory}}
> This is repeatable on -Dauth runs (we haven't been running them, have we?)
> Either its from the recent dir marker changes (initial hypothesis) or its
> been lurking a while and not been picked up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
