LeonGao91 commented on pull request #2288:
URL: https://github.com/apache/hadoop/pull/2288#issuecomment-714835959


   Thanks @Jing9 For the review!
   
   1) Very good idea, I will make a wrapper for the relationship. This will be 
useful if we want to update the ratio without restarting DN.
   
   2) Another good point, I did some investigation, although "reserve" is not 
being reported to NN, "NonDfsUsed" will be reported and double-counted. As 
discussed I will add an optional field to solve this.
   
   3) Yes, this is expected and we are looking at balancer/mover to kick-in to 
balance the datanode once the ratio is updated. I will put some java doc to 
explain this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to