ThAccart commented on pull request #2385:
URL: https://github.com/apache/hadoop/pull/2385#issuecomment-715360780
Hi
thanks for your comment.
The new code keeps the privious pattern matching test (sorry for the
misleading title) : it will accept a new param only if it is not found using
the previous pattern testing and not found using an equality testing (to
address the hadoop-azure hadoop-azure-datalake)
I also added a specific test for the pattern matching :
@test "hadoop_add_param (HADOOP-16649 c )" {
hadoop_add_param testvar Xmx -Xmx2048
hadoop_add_param testvar Xmx -Xmx128
hadoop_add_param testvar Xms -Xms32
echo ">${testvar}<"
[ "${testvar}" = "-Xmx2048 -Xms32" ]
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
