tasanuma commented on pull request #2418: URL: https://github.com/apache/hadoop/pull/2418#issuecomment-717765124
@aajisaka Thanks for updating PR. > According to the javadoc, this test case is to verify the default behavior. Don't set the default value (true) explicitly to verify the default behavior. I checked [HDFS-14653](https://issues.apache.org/jira/browse/HDFS-14653) again. `testNamenodeHeartBeatEnableDefault` checks that `DFS_ROUTER_NAMENODE_HEARTBEAT_ENABLE` is suppose to take the value of `DFS_ROUTER_HEARTBEAT_ENABLE` when `DFS_ROUTER_NAMENODE_HEARTBEAT_ENABLE` isn't explicitly specified. Therefore, the previous code here may not be wrong. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
