[ 
https://issues.apache.org/jira/browse/HADOOP-17224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226478#comment-17226478
 ] 

Ahmed Hussein commented on HADOOP-17224:
----------------------------------------

[~tasanuma], [~iwasakims] Thank you for creating that patch. I agree that it is 
important that the environment does not skip any tests.

However, IMHO that change was *never safe* to be merged into trunk without 
evaluating its side effect on all the test cases.
It blocked everyone else committing to Trunk.

Adding ISA-L triggered several failures listed under HDFS-15646 (i.e., 
HDFS-15643, HDFS-15654, HDFS-15461 ..etc)
Also, the testing run out of native memory, and it is possible that the bug was 
triggered as aside effect of this native library.

+I suggest that:+
* This change gets reverted.
* A thorough evaluation is performed on a local environment. This includes the 
native unit tests, and any test that might load the new library (EC, 
Stripedfiles..etc).
* When the failing units are fixed, then a PR that includes all the changes may 
be merged.
* keep an eye on the qbt-report to evaluate the environment post the merge.


CC: [~aajisaka], [~elgoiri], [~kihwal], [~daryn], [~weichiu], [~ayushtkn], 
[~ebadger]





> Install Intel ISA-L library in Dockerfile
> -----------------------------------------
>
>                 Key: HADOOP-17224
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17224
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Takanobu Asanuma
>            Assignee: Takanobu Asanuma
>            Priority: Major
>             Fix For: 3.4.0
>
>
> Currently, there is not isa-l library in the docker container, and jenkins 
> skips the natvie tests, TestNativeRSRawCoder and TestNativeXORRawCoder.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to