[
https://issues.apache.org/jira/browse/HADOOP-7627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119688#comment-13119688
]
Todd Lipcon commented on HADOOP-7627:
-------------------------------------
hm, you mean something like changing:
{code}
+ public static double getDoubleGauge(String name, MetricsRecordBuilder rb) {
+ ArgumentCaptor<Double> captor = ArgumentCaptor.forClass(Double.class);
+ verify(rb, atLeast(0)).addGauge(eqName(info(name, "")), captor.capture());
+ checkCaptured(captor, name);
+ return captor.getValue();
}
{code}
to more like
{code}
public static <T> T getGauge(String name, MetricsRecordBuilder rb, Class<T>
clazz) {
ArgumentCaptor<T> captor = ArgumentCaptor.forClass(clazz);
verify(rb, atLeast(0)).addGauge(eqName(info(name, "")), captor.capture());
checkCaptured(captor, name);
return captor.getValue();
}
{code}
?
> Improve MetricsAsserts to give more understandable output on failure
> --------------------------------------------------------------------
>
> Key: HADOOP-7627
> URL: https://issues.apache.org/jira/browse/HADOOP-7627
> Project: Hadoop Common
> Issue Type: Improvement
> Components: metrics, test
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: hadoop-7627.txt
>
>
> In developing a test case that uses MetricsAsserts, I had two issues:
> 1) the error output in the case that an assertion failed does not currently
> give any information as to the _actual_ value of the metric
> 2) there is no way to retrieve the metric variable (eg to assert that the sum
> of a metric over all DNs is equal to some value)
> This JIRA is to improve this test class to fix the above issues.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
