Hexiaoqiao commented on pull request #2437:
URL: https://github.com/apache/hadoop/pull/2437#issuecomment-722791873


   @maobaolong Thanks for your quick response. IIUC, value of allowed entry in 
audit log is decided if the request have permission to operate at the 
beginning. For this case, it makes sense to set allowed=false when delete root 
directory. I am not sure if it is reasonable that we also set allowed=false 
when `iip.getLastINode() = null`. Or the condition `iip.getLastINode() == null` 
could happen inner delete operation for some corner case? If not, the 
improvement is OK for me. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to