amahussein commented on pull request #2435: URL: https://github.com/apache/hadoop/pull/2435#issuecomment-723180594
> This change actually is leading to a lot of changes, though that is straightforward, but touching all the testcases....I think I have hard feelings for it(Folks would bug us, if that test fails for any other reason too). If in any case we want to go with the present approach I think other folks should also consider these many changes necessary. More over most of the people would not know or care to bother they have to use new configuration that you have introduced and they would directly spawn up a MiniDfsCluster, Thus in long run we might land up at the same problem, and again we have to to do this same exercise. > > If we just enable it in `MiniDfsCluster`, the change would be minimal and we can provide a flag, if enabled the config won't be bothered. I won't say the current approach is wrong in any way. It is completely correct, there can be multiple ways to do one thing. Just that I prefer keeping it in `MiniDfsCluster`, That was something the Jira tittle also...... This is a good perspective. Taking into consideration the current stability of Yetus, your approach should be wiser for the time being. We can always work on refactoring later when things are more stable. I will make another branch with the easy simple approach. Thanks @ayushtkn , I appreciate your feedback. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
