viirya commented on pull request #2350:
URL: https://github.com/apache/hadoop/pull/2350#issuecomment-723475628


   > I got a portability issue on bundled snappy .so of snappy-java in 
[xerial/snappy-java#256](https://github.com/xerial/snappy-java/pull/256). It 
could be downside that we can not directly control the portability. While I 
could not find how the bundled lz4 is built yet, it is enough portable since it 
has no dependency on other library?
   
   Thanks for asking. The underlying of lz4-java is lz4 
(https://lz4.github.io/lz4/), I think it is the same as current Hadoop's lz4 
library.
   
   ```
   LZ4 - Fast LZ compression algorithm
      Copyright (C) 2011-present, Yann Collet.
   ...
      You can contact the author at :
       - LZ4 homepage : http://www.lz4.org
       - LZ4 source repository : https://github.com/lz4/lz4
   ```
   
   So I think it should be as portable as before?
   
   BTW, for snappy-java and lz4-java, if no native library for your platform is 
found, it will fallback pure-java implementation. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to