[
https://issues.apache.org/jira/browse/HADOOP-17365?focusedWorklogId=509245&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-509245
]
ASF GitHub Bot logged work on HADOOP-17365:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/20 16:24
Start Date: 09/Nov/20 16:24
Worklog Time Spent: 10m
Work Description: adoroszlai opened a new pull request #2447:
URL: https://github.com/apache/hadoop/pull/2447
## What changes were proposed in this pull request?
Add some assertions to make sure the result of `rename()` over existing file
more closely matches expectations defined by contract options
`rename-returns-false-if-dest-exists` and `rename-overwrites-dest`.
https://issues.apache.org/jira/browse/HADOOP-17365
## How was this patch tested?
Ran related contract tests in Hadoop project:
```
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.025 s -
in org.apache.hadoop.fs.contract.rawlocal.TestRawlocalContractRename
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.993 s -
in org.apache.hadoop.fs.contract.localfs.TestLocalFSContractRename
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.654 s -
in org.apache.hadoop.fs.contract.hdfs.TestHDFSContractRename
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.14 s -
in org.apache.hadoop.fs.contract.router.TestRouterHDFSContractRename
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.295 s -
in org.apache.hadoop.fs.contract.router.web.TestRouterWebHDFSContractRename
```
(also some others for S3A and Azure, but tests in those were skipped).
Also ran Ozone [rename contract
test](https://github.com/apache/ozone/blob/master/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/contract/ITestOzoneContractRename.java)
with various combinations of these two contract options after overriding
`testRenameFileOverExistingFile()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 509245)
Remaining Estimate: 0h
Time Spent: 10m
> Contract test for renaming over existing file is too lenient
> ------------------------------------------------------------
>
> Key: HADOOP-17365
> URL: https://issues.apache.org/jira/browse/HADOOP-17365
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{AbstractContractRenameTest#testRenameFileOverExistingFile}} is too lenient
> in its assertions.
> * {{FileAlreadyExistsException}} is accepted regardless of "rename
> overwrites" and "rename returns false if exists" contract options. I think
> it should be accepted only if both of those options are false.
> * "rename returns false if exists" option is ignored if the file is not
> overwritten by the implementation.
> Also, I think the "rename returns false if exists" option is incorrectly
> inverted in the test, which it can get away with because the checks are loose.
> (Found this while looking at a change in Ozone FS implementation from
> throwing exception to returning false. The contract test unexpectedly passed
> without changing {{contract.xml}}.)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
