yzhangal commented on a change in pull request #2455:
URL: https://github.com/apache/hadoop/pull/2455#discussion_r522452788
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java
##########
@@ -431,8 +432,9 @@ public synchronized int read() throws IOException {
private void onReadFailure(IOException ioe, int length, boolean forceAbort)
throws IOException {
- LOG.info("Got exception while trying to read from stream {}" +
- " trying to recover: " + ioe, uri);
+ LOG.info("Got exception while trying to read from stream " + uri
+ + ", client: " + client + " object: " + object
Review comment:
Thanks a lot for the review Steve! Will address other comments asap.
The reason I made the change here is, the symptom is intermittent, and the
stack is helpful when we need to diagnose issues. I hope to catch it when it
occurs. My worry is that turning on debug will introduce a lot of other debug
messages to the logs. But if exceptions happen here very often, we can move
the stack printing to debug. Is that the case here though? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
