steveloughran commented on a change in pull request #2350:
URL: https://github.com/apache/hadoop/pull/2350#discussion_r525373324
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/lz4/Lz4Decompressor.java
##########
@@ -67,6 +55,15 @@
public Lz4Decompressor(int directBufferSize) {
this.directBufferSize = directBufferSize;
+ try {
+ LZ4Factory lz4Factory = LZ4Factory.fastestInstance();
+ lz4Decompressor = lz4Factory.safeDecompressor();
+ } catch (Throwable t) {
Review comment:
ok, so what's best here?
1. Catch AssertionError and wrap
2. Catch throwable, but with something ahead of it which will catch and
rethrow Error without wrapping. Because we shouldn't really be wrapping those
high-priority problems that aren't generally things to ignore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
