steveloughran commented on pull request #2350:
URL: https://github.com/apache/hadoop/pull/2350#issuecomment-729106816
LGTM. Only issue is should the catch be for all of Throwable or a subset. I
think I'll be happy to go with it as is
Two checkstyles to deal with; deprecation warning is notthing to worry about
```
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/CompressDecompressTester.java:476:
if (compressor.getClass().isAssignableFrom(Lz4Compressor.class)): 'if'
construct must use '{}'s. [NeedBraces]
./hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java:79:import
org.junit.Assert;:8: Unused import - org.junit.Assert. [UnusedImports]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
