[ 
https://issues.apache.org/jira/browse/HADOOP-17383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234221#comment-17234221
 ] 

Jungtaek Lim commented on HADOOP-17383:
---------------------------------------

[[email protected]]
This is a follow-up of HADOOP-17379, as I described in the PR. I took slightly 
different approach than I described, as this approach will also help some other 
implementations outside of Hadoop codebase.

I'd like to hear your insight on this - if you don't think this makes sense, 
please feel free to close this. Otherwise I could volunteer implementing this. 
Thanks in advance.

> AbstractS3ATokenIdentifier to provide issue date == created && max date == 
> expiry time
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-17383
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17383
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/s3
>    Affects Versions: 3.3.0
>            Reporter: Jungtaek Lim
>            Priority: Major
>
> As we've seen the behavior from HADOOP-17379, AbstractS3ATokenIdentifier 
> doesn't guarantee providing correct "issue date" and "max date" before 
> HADOOP-17379, and even after, "max date" is not a thing we can make a 
> guarantee only with AbstractS3ATokenIdentifier, as there's no information.
> In the meanwhile, I realized there're two methods in 
> AbstractS3ATokenIdentifier, getCreated() and getExpiryTime(), which feel like 
> the same purpose with getIssueDate() and getMaxDate() in 
> AbstractDelegationTokenIdentifier.
> If we think these pairs are doing the same, we can just override 
> AbstractS3ATokenIdentifier.getIssueDate() to call getCreated() && 
> AbstractS3ATokenIdentifier.getMaxDate() to call getExpiryTime().



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to