joshelser commented on pull request #2102: URL: https://github.com/apache/hadoop/pull/2102#issuecomment-729894664
My only thought at this point is: are we creating a dichotomy by having HFLUSH be deprecated in `StreamCapabilities` but not deprecated in `Syncable`? The argument is that we would never have an implementor of hflush which doesn't also implement hsync. However, every implementor of hsync should have an implementation for hflush (even if that implementation is to just invoke hsync). Now that I've come to this, I think outputstream.md adequately does this. Do you think it's appropriate to have a reciprocal javadoc reference from `Syncable` back to `StreamCapabilities`? I was thinking, if I was writing against this API, I might not know to go looking for StreamCapabilities if I just start digging through the Syncable API. I would defer to your judgement here (if you think it's unnecessary, I am not concerned). This was a fantastic and thorough read. Thanks for taking the time to do it, Steve! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
